[incubator-kie-issues-1401] Fix build kogito-examples.build-and-test in kogito nightly.native folder #1987

tkobayas · 2024-07-30T06:53:01Z

Issue:

Fix build kogito-examples.build-and-test in kogito nightly.native folder incubator-kie-issues#1401

#1986 is a fix for 10.0.x branch, but this PR is for main branch to be a fundamental fix:

update serverless-workflow examples versions
disable dmn-tracing-quarkus and trusty-tracing-quarkus-devservices

…in kogito nightly.native folder - Completely disabled dmn-tracing-quarkus and trusty-tracing-quarkus-devservices

tkobayas · 2024-07-30T06:57:23Z

.ci/jenkins/Jenkinsfile.setup-branch

+                        def pom = readMavenPom(file: 'pom.xml');
+                        def oldKogitoVersion = pom.version
+                        if (oldKogitoVersion == null) {
+                            echo "pom version is null. Using parent pom version"
+                            oldKogitoVersion = pom.parent.version
+                        }


I noticed that oldKogitoVersion was null in past logs because readMavenPom cannot resolve the parent version (I cannot find a reason from logs). But locally confirmed that pom.parent.version returns the expected version.

tkobayas · 2024-07-30T07:00:16Z

.ci/jenkins/Jenkinsfile.setup-branch

+                            // special case for serverless-workflow-examples-parent
+                            maven.mvnVersionsSet(
+                                    getMavenCommand('serverless-workflow-examples/serverless-workflow-examples-parent').withSettingsXmlFile(MAVEN_SETTINGS_FILE),
+                                    getKogitoVersion(),
+                                    true,
+                                    false
+                            )


serverless-workflow-examples project versions were not updated by mvnVersionsUpdateParentAndChildModules, because serverless-workflow-examples-parent itself was not updated. So I explicitly call mvnVersionsSet. The project directory is hard-coded, but I couldn't find another approach. Let me know if there is a better way.

tkobayas · 2024-07-30T07:02:18Z

.ci/jenkins/Jenkinsfile.setup-branch

-                            def status = sh(script: "grep -ir '${oldKogitoVersion}' --include='pom.xml'", returnStatus: true)
+                            def status = sh(script: "grep -ir '>${oldKogitoVersion}<' --include='pom.xml'", returnStatus: true)


Previously 10.0.999-SNAPSHOT may match when oldKogitoVersion is 999-SNAPSHOT. Added > < for precision.

tkobayas · 2024-07-30T07:04:55Z

.ci/jenkins/Jenkinsfile.setup-branch

-                                error "Old Kogito version ${oldKogitoVersion} is still present into the project... Please review it..."
+                                // some orphaned projects may still have the old version. not an error
+                                echo "Old Kogito version ${oldKogitoVersion} is still present into the project... Please review it..."


we may still have old versions because some projects are orphaned (not associated by <modules>), so mvn setVersion doesn't affect. It's not an error.

15:31:22 + grep -ir '>999-SNAPSHOT<' --include=pom.xml 15:31:22 kogito-quarkus-examples/dmn-tracing-quarkus/pom.xml: <kogito.bom.version>999-SNAPSHOT</kogito.bom.version> 15:31:22 kogito-quarkus-examples/dmn-tracing-quarkus/pom.xml: <version.org.kie.kogito>999-SNAPSHOT</version.org.kie.kogito> 15:31:22 kogito-quarkus-examples/trusty-tracing-quarkus-devservices/pom.xml: <kogito.bom.version>999-SNAPSHOT</kogito.bom.version> 15:31:22 kogito-quarkus-examples/trusty-tracing-quarkus-devservices/pom.xml: <version.org.kie.kogito>999-SNAPSHOT</version.org.kie.kogito> 15:31:22 serverless-workflow-examples/serverless-workflow-github-showcase/pom.xml: <version>999-SNAPSHOT</version> 15:31:22 serverless-workflow-examples/serverless-workflow-openvino-quarkus/pom.xml: <kogito.bom.version>999-SNAPSHOT</kogito.bom.version> 15:31:22 serverless-workflow-examples/serverless-workflow-subflows-event/pom.xml: <version>999-SNAPSHOT</version> 15:31:22 serverless-workflow-examples/serverless-workflow-subflows-event/pom.xml: <kogito.bom.version>999-SNAPSHOT</kogito.bom.version> 15:31:22 serverless-workflow-examples/serverless-workflow-subflows-event/pom.xml: <version.org.kie.kogito>999-SNAPSHOT</version.org.kie.kogito>

Btw, previously, oldKogitoVersion was null, so it didn't hit the error.

jstastny-cz

LGTM, Thanks @tkobayas

jstastny-cz · 2024-07-30T08:49:54Z

I suspect this problem might come from fact that the serverless-workflow-examples-parent is actually a sibling of modules which are using it.
I couldn't find the right place, but noticed, that the following construct is a problem on its own:
https://github.com/apache/incubator-kie-kogito-examples/blob/main/serverless-workflow-examples/pom.xml#L41

If the examples are built with "any" profile being active (either using -P or by any other activation means), this default profile is not activated at all, so the parent module falls out of the reactor.

tkobayas · 2024-07-30T09:25:07Z

Hi @pefernan , What do you think about @jstastny-cz 's point? : #1987 (comment) (I see that it was introduced by #1852 )

I think this is not rushed for v10 release, but if you think this can be improved, please file a GH issue.

kie-ci3 · 2024-07-30T10:44:49Z

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-examples -u #1987 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-examples-pr/job/PR-1987/1/display/redirect

Test results:

PASSED: 389
FAILED: 1

Those are the test failures:

org.acme.AcmeExchangeResourceIT.unauthorizedTest

java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor#startKeycloakContainer threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/keycloak/keycloak:23.0.7
at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:249)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:849)
at io.quarkus.builder.BuildContext.run(BuildContext.java:256)
at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
at java.base/java.lang.Thread.run(Thread.java:840)
at org.jboss.threads.JBossThread.run(JBossThread.java:501)
Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/keycloak/keycloak:23.0.7
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:359)
at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:330)
at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.lambda$startContainer$4(KeycloakDevServicesProcessor.java:376)
at java.base/java.util.Optional.orElseGet(Optional.java:364)
at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startContainer(KeycloakDevServicesProcessor.java:401)
at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:197)
... 11 more
Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception
at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:344)
... 16 more
Caused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:563)
at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:354)
at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
... 17 more
Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '.*Keycloak.*started.*'
at org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47)
at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)
at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:909)
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:500)
... 19 more

pefernan · 2024-07-30T11:32:52Z

@tkobayas oh. I don't remember the reason why, but the swf examples had no parent at the time and we needed that serverless-workflow-examples-parent so all the examples could have a common parent so they could inherit the java.module.name... that was a quick fix we did.

IDK if removing it and setting serverless-workflow-examples as with other examples (quarkus / springboot) would help here.

tkobayas · 2024-07-31T07:07:53Z

Thanks @pefernan , I filed #1989

For now, we may go ahead with this PR.

tkobayas · 2024-07-31T07:14:17Z

jenkins/pr-head: This error is being seen these days. Not related to this PR.

[2024-07-30T10:20:15.960Z] [ERROR] Tests run: 4, Failures: 0, Errors: 1, Skipped: 3, Time elapsed: 80.135 s <<< FAILURE! - in org.acme.AcmeExchangeResourceIT
...
[2024-07-30T10:20:15.960Z] Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/keycloak/keycloak:23.0.7

rodrigonull

LGTM. Thanks!

tkobayas · 2024-08-15T06:01:35Z

The setup-branch change might be affected by the dev ML discussion "[DISCUSS] Kogito Examples and Properties". But at the moment, it's safe to merge, I think.

…in kogito nightly.native folder (apache#1987) * [incubator-kie-issues-1401] Fix build kogito-examples.build-and-test in kogito nightly.native folder - Completely disabled dmn-tracing-quarkus and trusty-tracing-quarkus-devservices

tkobayas added 2 commits July 29, 2024 14:49

[incubator-kie-issues-1401] Fix build kogito-examples.build-and-test …

0e3c2d4

…in kogito nightly.native folder - Completely disabled dmn-tracing-quarkus and trusty-tracing-quarkus-devservices

- Improve version-update

70cb9ac

tkobayas commented Jul 30, 2024

View reviewed changes

tkobayas mentioned this pull request Jul 30, 2024

[10.0.x] [incubator-kie-issues-1401] Fix build kogito-examples.build-and-test in kogito nightly.native folder #1986

Merged

jstastny-cz approved these changes Jul 30, 2024

View reviewed changes

tkobayas requested review from rodrigonull and pibizza July 30, 2024 09:08

tkobayas mentioned this pull request Jul 31, 2024

Improve serverless-workflow-examples-parent structure #1989

Open

rodrigonull approved these changes Aug 2, 2024

View reviewed changes

tkobayas merged commit 9253d3b into apache:main Aug 15, 2024
4 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[incubator-kie-issues-1401] Fix build kogito-examples.build-and-test in kogito nightly.native folder #1987

[incubator-kie-issues-1401] Fix build kogito-examples.build-and-test in kogito nightly.native folder #1987

tkobayas commented Jul 30, 2024 •

edited by yesamer

Loading

tkobayas Jul 30, 2024 •

edited

Loading

tkobayas Jul 30, 2024 •

edited

Loading

tkobayas Jul 30, 2024

tkobayas Jul 30, 2024 •

edited

Loading

jstastny-cz left a comment

jstastny-cz commented Jul 30, 2024

tkobayas commented Jul 30, 2024

kie-ci3 commented Jul 30, 2024

pefernan commented Jul 30, 2024

tkobayas commented Jul 31, 2024

tkobayas commented Jul 31, 2024

rodrigonull left a comment

tkobayas commented Aug 15, 2024

		def status = sh(script: "grep -ir '${oldKogitoVersion}' --include='pom.xml'", returnStatus: true)
		def status = sh(script: "grep -ir '>${oldKogitoVersion}<' --include='pom.xml'", returnStatus: true)

[incubator-kie-issues-1401] Fix build kogito-examples.build-and-test in kogito nightly.native folder #1987

[incubator-kie-issues-1401] Fix build kogito-examples.build-and-test in kogito nightly.native folder #1987

Conversation

tkobayas commented Jul 30, 2024 • edited by yesamer Loading

Issue:

tkobayas Jul 30, 2024 • edited Loading

Choose a reason for hiding this comment

tkobayas Jul 30, 2024 • edited Loading

Choose a reason for hiding this comment

tkobayas Jul 30, 2024

Choose a reason for hiding this comment

tkobayas Jul 30, 2024 • edited Loading

Choose a reason for hiding this comment

jstastny-cz left a comment

Choose a reason for hiding this comment

jstastny-cz commented Jul 30, 2024

tkobayas commented Jul 30, 2024

kie-ci3 commented Jul 30, 2024

pefernan commented Jul 30, 2024

tkobayas commented Jul 31, 2024

tkobayas commented Jul 31, 2024

rodrigonull left a comment

Choose a reason for hiding this comment

tkobayas commented Aug 15, 2024

tkobayas commented Jul 30, 2024 •

edited by yesamer

Loading

tkobayas Jul 30, 2024 •

edited

Loading

tkobayas Jul 30, 2024 •

edited

Loading

tkobayas Jul 30, 2024 •

edited

Loading